Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Support dark mode #2440

Open
JudahGabriel opened this issue Oct 27, 2021 · 5 comments
Open

[iOS] Support dark mode #2440

JudahGabriel opened this issue Oct 27, 2021 · 5 comments

Comments

@JudahGabriel
Copy link
Contributor

PWAs can support dark mode via CSS prefer-color-scheme, which is supported on WebKit.

However, PWABuilder's iOS template doesn't include dark mode support for the splash screen nor the status bar. This functionality would be fairly trivial to add to the iOS project template.

If this is important to you, please 👍 the issue.

@khmyznikov
Copy link
Contributor

photo_2021-10-27_11-49-01
But it does... 🤔

@JudahGabriel
Copy link
Contributor Author

Gleb, in our template, we allow the user to specify splash background color, auto-populating it with your manifest's background_color. It's cool, but I assume it breaks the dark mode support.

There is a broader web standards discussion for manifest color values being limited to color schemes. But until then, we'll need our template to let users specify both splash color and dark mode splash color. Progress bar color + dark mode progress bar color, and status bar color + dark mode status bar color as well.

IIRC, our Android platform (combined with Google's Bubblewrap) does the same.

@khmyznikov
Copy link
Contributor

This could be optional at least. Because big bright background in a dark room, especially on new iPhones, could be painful.
We have a brand color too, but we decided to leave a standard black/white splash to avoid annoying people.

@JudahGabriel
Copy link
Contributor Author

Gotcha. I'd love to tackle this in v1.1 in November.

@jgw96 jgw96 transferred this issue from pwa-builder/pwabuilder-ios Jan 13, 2022
@ghost ghost added the needs triage 🔍 label Jan 13, 2022
@ghost
Copy link

ghost commented Jan 13, 2022

Hello JudahGabriel, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will investigate the issue and help solve it ASAP. Other community members may also look into the issue and provide feedback 🙌

@nmetulev nmetulev changed the title Support dark mode [iOS] Support dark mode Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants