Skip to content

Commit c120959

Browse files
congwangummakynes
authored andcommitted
netfilter: fix a use-after-free in mtype_destroy()
map->members is freed by ip_set_free() right before using it in mtype_ext_cleanup() again. So we just have to move it down. Reported-by: syzbot+4c3cc6dbe7259dbf9054@syzkaller.appspotmail.com Fixes: 40cd63b ("netfilter: ipset: Support extensions which need a per data destroy function") Acked-by: Jozsef Kadlecsik <kadlec@netfilter.org> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
1 parent c9f5304 commit c120959

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/netfilter/ipset/ip_set_bitmap_gen.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,9 @@ mtype_destroy(struct ip_set *set)
6060
if (SET_WITH_TIMEOUT(set))
6161
del_timer_sync(&map->gc);
6262

63-
ip_set_free(map->members);
6463
if (set->dsize && set->extensions & IPSET_EXT_DESTROY)
6564
mtype_ext_cleanup(set);
65+
ip_set_free(map->members);
6666
ip_set_free(map);
6767

6868
set->data = NULL;

0 commit comments

Comments
 (0)