Skip to content

Commit 71a06f1

Browse files
miquelraynalStefan-Schmidt
authored andcommitted
mac802154: Fix possible double free upon parsing error
Commit 4d1c7d8 ("mac802154: Move an skb free within the rx path") tried to simplify error handling within the receive path by moving the kfree_skb() call at the very end of the top-level function but missed one kfree_skb() called upon frame parsing error. Prevent this possible double free from happening. Fixes: 4d1c7d8 ("mac802154: Move an skb free within the rx path") Reported-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/r/20221216235742.646134-1-miquel.raynal@bootlin.com Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
1 parent 9cd3fd2 commit 71a06f1

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

net/mac802154/rx.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,6 @@ __ieee802154_rx_handle_packet(struct ieee802154_local *local,
213213
ret = ieee802154_parse_frame_start(skb, &hdr);
214214
if (ret) {
215215
pr_debug("got invalid frame\n");
216-
kfree_skb(skb);
217216
return;
218217
}
219218

0 commit comments

Comments
 (0)