Skip to content

Fix compiler failure #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 10, 2022
Merged

Fix compiler failure #48

merged 4 commits into from
Mar 10, 2022

Conversation

philipturner
Copy link
Contributor

I came across a compiler failure while working on Swift-Colab. There is a build error where passing a simple PythonClass.Members literal makes the literal's type ambiguous. It is confused with [String: PythonObject]. To fix this error, we add a @_disfavoredOverload attribute to the more specific initializer. The reproducer is located in the new test case.

To reproduce the build failure, delete the @_disfavoredOverload attribute that was added and run the package tests.

@philipturner
Copy link
Contributor Author

I also fixed two words that should have been escaped with backticks previously.

@pvieito pvieito merged commit 05a130d into pvieito:master Mar 10, 2022
@pvieito
Copy link
Owner

pvieito commented Mar 10, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants