es-module-shims 1.5.12#298
Merged
JordanMartinez merged 2 commits intopurescript:masterfrom Aug 16, 2022
Merged
Conversation
Version 1.5.12 is currently - including the latest bug fix 1.5.15 - the best version for the project where the examples work in all tested browsers. See these discussion for more details: <purescript#297 (comment)> <guybedford/es-module-shims#324 (comment)>
JordanMartinez
approved these changes
Aug 15, 2022
Contributor
JordanMartinez
left a comment
JordanMartinez
left a comment
There was a problem hiding this comment.
I've verified that this works for me locally.
Contributor
|
@andys8 Mind adding a changelog entry for this? |
Contributor
Author
|
7f20455 ✔️ |
Contributor
|
@natefaubion Can I get an approval on this? |
natefaubion
approved these changes
Aug 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 1.5.12 is currently - including the latest bug fix 1.5.15 - the best version for the project where the examples work in all tested browsers.
See these discussions for more details: