Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double main call by updating es-module-shims to 1.5.6 #279

Merged
merged 2 commits into from
Jun 18, 2022
Merged

Fix double main call by updating es-module-shims to 1.5.6 #279

merged 2 commits into from
Jun 18, 2022

Conversation

JordanMartinez
Copy link
Contributor

@JordanMartinez JordanMartinez commented Jun 18, 2022

Description of the change

Currently, try.purescript.org will run the main function twice when one uses TP.render =<< TP.withConsole <<< log "foo"

Updating es-module-shims to the next version fixes this on Firefox when I test the client against the production server.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0 by @)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez
Copy link
Contributor Author

Here's a link to the release: https://github.com/guybedford/es-module-shims/releases/tag/1.5.6

@JordanMartinez JordanMartinez changed the title Fix double main call by updating es-shims to 1.5.6 Fix double main call by updating es-module-shims to 1.5.6 Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants