Implement auth and transfer commands#1298
Merged
Merged
Conversation
Collaborator
|
Absolutely no problem, I assumed it would be this way. I'm happy to keep rebasing until it's time. |
Collaborator
|
I'm afraid it'll take me a few days to review though. This is quite large. |
Member
Author
Member
Author
|
Of course happy to have @thomashoneyman's review as well here if it doesn't take away time from other things 🙂 |
fsoikin
reviewed
Nov 8, 2024
fsoikin
reviewed
Nov 8, 2024
fsoikin
approved these changes
Nov 8, 2024
Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com>
Co-authored-by: Fyodor Soikin <name.fa@gmail.com>
Co-authored-by: Fyodor Soikin <name.fa@gmail.com>
Co-authored-by: Fyodor Soikin <name.fa@gmail.com>
Co-authored-by: Fyodor Soikin <name.fa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We fix #1123 by adding the
authandregistry transfercommands, to allow for authenticated interactions with the Registry. Theunpublishcommand is still unimplemented, but it should be easy now that the rest of the scaffolding is in place.This PR includes a whole set of tests to verify that things do what they should, and docs to inform users how the authenticated flow looks like.
@fsoikin I intend to merge this before #1296 since I've been rebasing it for months already and I'd love to not have to do it once more 😄
(this fixes #1294 as well)