-
Notifications
You must be signed in to change notification settings - Fork 23
Add more documentation examples #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
milesfrain
wants to merge
1
commit into
purescript:master
Choose a base branch
from
milesfrain:docs-details
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,19 @@ import Partial.Unsafe (unsafePartial) | |
-- | operation of a non-empty list or array; it always returns a value, and | ||
-- | then optionally a value to continue unfolding from. | ||
-- | | ||
-- | For example: | ||
-- | ``` purescript | ||
-- | g :: Int -> Tuple Int (Maybe Int) | ||
-- | g n | n <= 0 = Tuple 0 Nothing | ||
-- | g n = Tuple n (Just (n - 1)) | ||
-- | | ||
-- | unfoldr1 g 3 == NEA.cons' 3 [2, 1, 0] | ||
-- | unfoldr1 g 3 == NEL.cons' 3 (2 : 1 : 0 : Nil) | ||
-- | -- Also produces structures of types which can be empty | ||
-- | unfoldr1 g 3 == [3, 2, 1, 0] | ||
-- | unfoldr1 g 3 == 3 : 2 : 1 : 0 : Nil | ||
-- | ``` | ||
-- | | ||
-- | Note that, in order to provide an `Unfoldable1 t` instance, `t` need not | ||
-- | be a type which is guaranteed to be non-empty. For example, the fact that | ||
-- | lists can be empty does not prevent us from providing an | ||
|
@@ -58,8 +71,14 @@ foreign import unfoldr1ArrayImpl | |
-- | `n` less than 1 will be treated as 1. | ||
-- | | ||
-- | ``` purescript | ||
-- | replicate1 2 "foo" == (NEL.cons "foo" (NEL.singleton "foo") :: NEL.NonEmptyList String) | ||
-- | replicate1 0 "foo" == (NEL.singleton "foo" :: NEL.NonEmptyList String) | ||
-- | > replicate1 2 "foo" :: NonEmptyList _ | ||
-- | (NonEmptyList (NonEmpty "foo" ("foo" : Nil))) | ||
-- | > replicate1 0 "foo" :: NonEmptyArray _ | ||
-- | (NonEmptyArray ["foo"]) | ||
-- | > replicate1 0 "foo" :: List _ | ||
-- | ("foo" : Nil) | ||
-- | > replicate1 2 "foo" :: Array _ | ||
-- | ["foo","foo"] | ||
-- | ``` | ||
replicate1 :: forall f a. Unfoldable1 f => Int -> a -> f a | ||
replicate1 n v = unfoldr1 step (n - 1) | ||
|
@@ -73,10 +92,10 @@ replicate1 n v = unfoldr1 step (n - 1) | |
-- | than 1 will be treated as 1), and accumulate the results. | ||
-- | | ||
-- | ``` purescript | ||
-- | > replicate1A 2 (randomInt 1 10) :: Effect (NEL.NonEmptyList Int) | ||
-- | > replicate1A 2 (randomInt 1 10) :: Effect (NonEmptyList Int) | ||
-- | (NonEmptyList (NonEmpty 8 (2 : Nil))) | ||
-- | > replicate1A 0 (randomInt 1 10) :: Effect (NEL.NonEmptyList Int) | ||
-- | (NonEmptyList (NonEmpty 4 Nil)) | ||
-- | > replicate1A 0 (randomInt 1 10) :: _ (NonEmptyArray _) | ||
-- | (NonEmptyArray [3]) | ||
Comment on lines
+95
to
+98
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should these work too? Missing replicate1A 0 (randomInt 1 10) :: _ (List _)
replicate1A 2 (randomInt 1 10) :: _ (Array _) |
||
-- | ``` | ||
replicate1A | ||
:: forall m f a | ||
|
@@ -91,7 +110,8 @@ replicate1A n m = sequence1 (replicate1 n m) | |
-- | Contain a single value. For example: | ||
-- | | ||
-- | ``` purescript | ||
-- | singleton "foo" == (NEL.singleton "foo" :: NEL.NonEmptyList String) | ||
-- | singleton "foo" == (NEL.singleton "foo" :: NonEmptyList String) | ||
-- | singleton "foo" == (NEA.singleton "foo" :: NonEmptyArray String) | ||
-- | ``` | ||
singleton :: forall f a. Unfoldable1 f => a -> f a | ||
singleton = replicate1 1 | ||
|
@@ -103,6 +123,8 @@ singleton = replicate1 1 | |
-- | range 0 0 == (NEL.singleton 0 :: NEL.NonEmptyList Int) | ||
-- | range 1 2 == (NEL.cons 1 (NEL.singleton 2) :: NEL.NonEmptyList Int) | ||
-- | range 2 0 == (NEL.cons 2 (NEL.cons 1 (NEL.singleton 0)) :: NEL.NonEmptyList Int) | ||
Comment on lines
123
to
125
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Writing the Non-empty examples is kinda clumsy without purescript/purescript-lists#190 |
||
-- | range 1 3 == [1, 2, 3] | ||
-- | range 1 3 == 1 : 2 : 3 : Nil | ||
-- | ``` | ||
range :: forall f. Unfoldable1 f => Int -> Int -> f Int | ||
range start end = | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if this REPL-style sequence is clearer:
Also, there's some inconsistency with
show
forNonEmptyArray
vsNonEmptyList
. TheArray
version is a lot more concise.