fixing genericCoarbitrary #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems sensible to me. I wonder if we should regard this as a breaking or minor-level change though, as it's possible someone was relying on the more specialized type for type inference. Admittedly that possibility seems a bit remote. |
hdgarrood
approved these changes
Mar 7, 2019
|
I think it should probably be a hard version change rather than minor; because the type signature clearly changes. However, anyone using the function would be restricted to site-based usage, in which the generator perturbed would be of the same type as the indexed value - such that, if replaced by my more general version, it should still compile a-ok. |
thomashoneyman
approved these changes
Dec 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coarbitraryis intended to perturb an unrelatedGenwith data that implements the typeclass - it's not intended to be explicitly related to the generated data.