Skip to content

Fix warnings revealed by v0.14.1 PS release #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2021
Merged

Fix warnings revealed by v0.14.1 PS release #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88cb5ba
Fix warnings revealed by v0.14.1 PS release
JordanMartinez Apr 18, 2021
5305af4
Update changelog
JordanMartinez Apr 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ New features:
Bugfixes:

Other improvements:
- Fix warnings revealed by `v0.14.1` PS release (#262)

## [v5.0.0](https://github.com/purescript/purescript-prelude/releases/tag/v5.0.0) - 2021-02-26

Expand Down
4 changes: 2 additions & 2 deletions src/Data/Ord/Generic.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ instance genericOrdNoArguments :: GenericOrd NoArguments where
instance genericOrdSum :: (GenericOrd a, GenericOrd b) => GenericOrd (Sum a b) where
genericCompare' (Inl a1) (Inl a2) = genericCompare' a1 a2
genericCompare' (Inr b1) (Inr b2) = genericCompare' b1 b2
genericCompare' (Inl b1) (Inr b2) = LT
genericCompare' (Inr b1) (Inl b2) = GT
genericCompare' (Inl _) (Inr _) = LT
genericCompare' (Inr _) (Inl _) = GT

instance genericOrdProduct :: (GenericOrd a, GenericOrd b) => GenericOrd (Product a b) where
genericCompare' (Product a1 b1) (Product a2 b2) =
Expand Down