-
Notifications
You must be signed in to change notification settings - Fork 50
Law-abiding Apply NonEmptyList
that agrees with Apply List
#221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
UnrelatedString
wants to merge
36
commits into
purescript:master
from
UnrelatedString:fixed-apply-instance
Closed
Law-abiding Apply NonEmptyList
that agrees with Apply List
#221
UnrelatedString
wants to merge
36
commits into
purescript:master
from
UnrelatedString:fixed-apply-instance
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
~~made the CI woke~~ making CI workflow run on renamed main branch after splitting off the unfoldable1 feature branch so I can PR said feature branch to both my own main branch and the official master branch without having to undo the rename in ci.yml for the official PR
Fixed my bad guess for PR name
Make `Data.List.NonEmpty.toUnfoldable` and `Data.List.Lazy.NonEmpty.toUnfoldable` work with `Unfoldable1`
…ast this is *getting* there and a vastly better idea than the other stuff I tried. afraid of actually putting a spago.yaml in the top level since that could mess with publishing though... copying the dependencies in seems bad for maintainability but for something this low level with so few dependencies I guess it should be Fine
…ing's deprecated. LMAO. aaaaand of course having this as its own recursive dependency kinda messes things up after all :P
… instead of spago lol
…t exist on bower and I still get four modules not found ;_;
…rce latest thing messed up the existing committed resolve and now I just have to save it all manually don't I
… does give me an idea though
…s than I are probably going to redo like most of this PR anyways lol
...also realized there are personal tweaks to the CI in there that weren't supposed to be in ANY PR. oops |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Rewrote the faulty
to
and likewise for the lazy equivalent. The majority of the commits were adding massively-overkill test machinery because I couldn't actually think of an example of how this failed to obey the
Apply
law without randomly generating one, but this can safely be removed (and I will gladly do so, or even make a new PR from a branch without those commits, if asked) because the single new testshould suffice.
...I also accidentally included the contents of my earlier PR #220,
Checklist: