add getter for error's name when available

[KtorZ]

Hi folks!

I've added a small accessor which retrieves the name of an error when available. The property is specified by the ECMAScript spec 5.1 and is quite useful to perform pattern matching in a relatively reliable way.

In some cases and for some browsers though, the property name remains undefined in which case I chose to fallback to the initial name of 'Error' (instead of going for a Error -> Maybe String as I find the former approach more practical).

Let me know 👍

[paf31]

Looks good, but "Error" seems like maybe not the best default, since throw new Error(...) will be indistinguishable from throw "error!".

Maybe something like "Unknown error", what do you think?

[KtorZ]

Well, I have picked "Error" exactly for that purpose. Here's my rational:

(Almost) any type can be thrown in JavaScript; yet it's not the case in PureScript (so far). Therefore every error which is going to be manipulated from PureScript is actually going to be an instance of Error. Hence the default.

[paf31]

@garyb Any thoughts before I merge this one?

[garyb]

Looks fine to me, I think "Error" is a good default value too given the description in the spec.

[paf31]

Thanks!