Skip to content

Add extend instance for Array #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
garyb merged 1 commit into from
May 29, 2017
Merged

Add extend instance for Array #44

garyb merged 1 commit into from
May 29, 2017

Conversation

@i-am-tom
Copy link

@i-am-tom i-am-tom commented May 28, 2017

With some advice from @garyb, I've added the arrayExtend function (via FFI, needs must), and given Array an Extend implementation. Behaviour is hopefully as expected:

> extend sum [10,5,4,3]
[22,12,7,3]

> extend sum [] :: Array Int
[]

Add extend instance for Array
e2ce8e0 
While being defined for `List`, the `Array` primitive didn't previously
have a defined `Extend` instance. This has been added.
@paf31
Copy link
Contributor

paf31 commented May 28, 2017

👍 LGTM!

@garyb
Copy link
Member

garyb commented May 29, 2017

Thanks!

@garyb garyb merged commit efaccc9 into purescript:master May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@i-am-tom @paf31 @garyb