trivial Lazy instance for functions #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Might be worth waiting until I add some tests on this. Not sure it's working exactly the way I thought it would. |
|
In particular, I'm not sure if this makes any sense given that Maybe it still makes sense though in those contexts in which you have a @paf31 perhaps you have some advice here? |
|
Got it to stop diverging... Will update shortly. |
Add tests for this.
|
Okay, this feels right now. Happy to have this reviewed. |
garyb
reviewed
Apr 4, 2017
src/Control/Lazy.purs
Outdated
| @@ -11,7 +11,7 @@ class Lazy l where | |||
| defer :: (Unit -> l) -> l | |||
|
|
|||
| instance lazyFn :: Lazy (a -> b) where | |||
| defer f = f unit | |||
| defer f = \x -> f unit x | |||
There was a problem hiding this comment.
Now I see it, this definitely looks like the right thing 👍
This was referenced Apr 5, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.