Skip to content

Prepare for 2.0 release #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 7, 2016
Merged

Prepare for 2.0 release #73

merged 4 commits into from
Oct 7, 2016

Conversation

garyb
Copy link
Member

@garyb garyb commented Oct 7, 2016

This re-exports the more common stuff out of Foldable and Traversable. Anything else we want to include?

Resolves #72, resolves #70

As for #71, I guess we can do that post-release, since it shouldn't affect the interface.

@paf31
Copy link
Contributor

paf31 commented Oct 7, 2016

do we want to limit foldM to MonadRec?

I would say people should use FreeT to make things stack-safe first, but there is a valid use case where that might be overkill: using foldM with List to generate a graph. Indeed, I use that in the book, and I wouldn't want to have to drag in FreeT there (which probably means it is too advanced). So I think yes, let's add this as a separate function for now.

@garyb
Copy link
Member Author

garyb commented Oct 7, 2016

There's also the point raised in purescript/purescript#2359 about the not insignificant overhead if you don't need it too. I'll add it as a separate thing then. foldMRec good for the name?

@garyb
Copy link
Member Author

garyb commented Oct 7, 2016

I went with foldRecM to match tailRecM, etc.

@garyb garyb merged commit a8e463b into master Oct 7, 2016
@garyb garyb deleted the bump branch October 7, 2016 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

foldM is not tail recursive and crashes on large collections
3 participants