ST.unsafeThaw #123
Merged
ST.unsafeThaw #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdgarrood
reviewed
Jan 20, 2018
src/Data/Array/ST.purs
Outdated
| @@ -66,6 +68,11 @@ withArray f xs = do | |||
| unsafeFreeze :: forall a r h. STArray h a -> Eff (st :: ST h | r) (Array a) | |||
| unsafeFreeze = pure <<< (unsafeCoerce :: STArray h a -> Array a) | |||
|
|
|||
| -- | O(1) Convert an immutable array to a mutable array, without copying. The mutable | |||
| -- | array must not be mutated. | |||
There was a problem hiding this comment.
I think writing "the mutable array must not be mutated" seems to defeat the point of this function: if you have an Array a and you want to convert it into an STArray h a, that's probably because you want to mutate it, right? I think it would make more sense to say "the input array must not be used afterwards".
There was a problem hiding this comment.
Right. Will fix.
addresses purescript#118
matthewleon
force-pushed
the
unsafeThaw
branch
from
941c4ee to
30ffb23
Compare
|
Modified according to review comment. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #118