Open
Conversation
We should point this out to users. Not sure if this the best place for it. Could alternatively do: - Earlier in "Setting up the Development Environment" - Later in "What Next?"
Collaborator
|
Putting it in "What next" sounds preferable to me, since we aren't doing anything that requires it in the guide, and people will be able to see something happen faster if they don't try to install editor tooling first. I think there's also a risk that having editor tooling running alongside the commands the guide asks you to perform might confuse things. |
Contributor
|
This PR hasn't been merged because I'm not sure that should be in the Getting Started section if it's in reference to the Book. Shouldn't the Book clarify that instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should point this out to users. Not sure if this the best place for it.
Could alternatively do: