Skip to content

Point to compiler's install guide #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2020
Merged

Conversation

milesfrain
Copy link
Contributor

Boosting heading sizes too so they're slightly larger than bold text.

Boosting heading sizes too so they're slightly larger than bold text.
@hdgarrood
Copy link
Collaborator

Thanks, but I don't think this should be part of the main getting started guide. I'd prefer a link to the INSTALL.md file in the compiler repo, which covers installation FAQs.

@milesfrain
Copy link
Contributor Author

which covers installation FAQs.

Does this FAQ need to be created?
https://github.com/purescript/purescript/blob/master/INSTALL.md

The motivation for a troubleshooting section here is that we often need to help beginners through EACCES and libtinfo errors on slack. For example, search:

in:#purescript-beginners in:#purescript EACCES
in:#purescript-beginners in:#purescript libtinfo

Given that lots of users already miss the EACCES note in these instructions, I'm not sure how likely they'll be to find their solution in a linked FAQ. Hoping these prominent error snippets on this same page will help them see the connection.

@hdgarrood
Copy link
Collaborator

I don’t understand your question about whether it needs to be created? That INSTALL.md file you linked already covers some common questions and issues that arise for people trying to install the compiler, such as supported OS versions, how to build it from source, and installing ncurses.

I don’t think we can assume that people are reading this guide and missing the existing stuff. There are many “getting started” resources out there aside from this one, or people might not even be using any, they might just be running npm install -g purescript (as suggested on purescript.org, for instance). I think a link to the INSTALL.md file can (and should) be prominent here without having to take up space in this file describing specific problems and solutions.

@hdgarrood
Copy link
Collaborator

I think the most effective approach would probably be to get the npm installer to try to identify these issues where they occur and print appropriate error messages.

@milesfrain
Copy link
Contributor Author

I don’t understand your question about whether it needs to be created?

I meant whether a specific "FAQ" or "Troubleshooting" section should be created in INSTALL.md to help users more easily identify where to find these solutions.

as suggested on purescript.org

That's a good point. Perhaps link to these same troubleshooting tips from there too.

@hdgarrood
Copy link
Collaborator

I don’t think a separate section called “troubleshooting” or “FAQ” should be created in INSTALL.md, since the focus of the majority of that file is already to help people install the compiler or fix common installation issues. I think including the EACCES error in there too would be a good idea.

milesfrain added a commit to milesfrain/purescript.github.io that referenced this pull request Jun 26, 2020
hdgarrood pushed a commit to purescript/purescript that referenced this pull request Aug 20, 2020
* Add troubleshooting steps for libtinfo and EACCES errors

See purescript/documentation#323 (comment)

* Absorb `libtinfo` troubleshooting, change "here" link

* Separate troubleshooting steps for libtinfo5

* Suggest installing both libtinfo5 and libncurses5-dev
Copy link
Member

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are sensible updates to make to the getting started guide (they're quite minimal at this point).


You'll need to install [Node.js and npm](https://docs.npmjs.com/getting-started/installing-node). We recommend installing [Node.js and npm via a node version manager](https://docs.npmjs.com/getting-started/installing-node) to avoid issues with installing packages globally. If you choose to install it manually, you might experience the [`EACCES` error when installing packages globally](https://docs.npmjs.com/getting-started/fixing-npm-permissions#option-1-change-the-permission-to-npm-s-default-directory).
You'll need to install [Node.js and npm](https://docs.npmjs.com/downloading-and-installing-node-js-and-npm#using-a-node-version-manager-to-install-nodejs-and-npm). We recommend installing [Node.js and npm via a node version manager](https://docs.npmjs.com/getting-started/installing-node) to avoid issues with installing packages globally. If you choose to install it manually, you might experience the [`EACCES` error when installing packages globally](https://docs.npmjs.com/getting-started/fixing-npm-permissions).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this could say "We suggest installing the compiler with NPM, though other installation methods exist" and link over to the INSTALL.md file?

Copy link
Contributor Author

@milesfrain milesfrain Aug 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INSTALL.md is linked below for troubleshooting. But I can link to it again in this paragraph. Not sure exactly what would be the best wording here. If you have something specific in-mind, feel free to edit the file in this PR and re-commit to my branch. I believe the github interface makes this easy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally went with the minimal-change strategy for this section by just adding the correct anchors, but will go ahead with my interpretation of your suggestion.

milesfrain added a commit to milesfrain/purescript that referenced this pull request Aug 24, 2020
Removing some content from the getting started guide in favor of linking here (purescript/documentation#323), so this PR ensures that no content is lost.
@milesfrain
Copy link
Contributor Author

Applied latest review feedback and also simplified the installation instructions by linking to the compiler's INSTALL.md.

The removed content is being reintroduced in purescript/purescript#3920

@milesfrain milesfrain changed the title Add troubleshooting section Point to compiler's install guide Aug 26, 2020
@hdgarrood hdgarrood merged commit 4ba614e into purescript:master Sep 5, 2020
@milesfrain milesfrain deleted the patch-3 branch September 6, 2020 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants