You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I notice you implemented drop but not end (which is confusingly also called endDrag in the React docs, if I'm reading them right?).
May I ask why? Do you think end isn't necessary, or did you just not get around to it yet? In my experience drop and endDrag behave differently. #10 Do you think purescript-react-dnd-basic should implement endDrag, and if so, do you have any advice about how to approach it?
The text was updated successfully, but these errors were encountered:
Maybe a useEffect hook would work for firing side-effects after the render from the drop event of a useDrop hook, as if the side-effects had been fired from endDrag.
I just didn't get around to it. It isn't necessary for the simpler use cases, but if you're tying more of your UI to drag states and need to control other side effects it might be easier to do that from these "drag lifecycle" handlers. Your useEffect suggestion will probably work as well.
I'm not opposed to adding more of the react-dnd api, but I don't have the bandwidth to do it myself anytime soon.
Thanks for upgrading this library to Hooks.
I notice you implemented
drop
but notend
(which is confusingly also calledendDrag
in the React docs, if I'm reading them right?).May I ask why? Do you think
end
isn't necessary, or did you just not get around to it yet? In my experiencedrop
andendDrag
behave differently. #10 Do you think purescript-react-dnd-basic should implementendDrag
, and if so, do you have any advice about how to approach it?The text was updated successfully, but these errors were encountered: