Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems fine to switch to spago now #137

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Seems fine to switch to spago now #137

merged 1 commit into from
Mar 5, 2021

Conversation

megamaddu
Copy link
Member

Spago made it easier to test the 0.14 changes. If this looks good I'll convert the others as well.

@megamaddu megamaddu self-assigned this Mar 3, 2021
@hdgarrood
Copy link
Contributor

I personally am still not sold on Spago for libraries: purescript/purescript#3942 (comment)

If we are going to switch then I think we should ensure that the bower.json we have checked in matches the one Spago would generate for us, and that it is exercised in CI (i.e. you can install dependencies with it and run tests with it). If we don't do this, then we might struggle to publish the package to Pursuit.

@megamaddu
Copy link
Member Author

Hmm, I see what you mean. I've been using the spago-generated bower.json in react-basic-hooks for a while and kind of assumed that was the "correct" approach (i.e. keep it working with the latest package set and emit a compatible bower.json for those users).

@megamaddu
Copy link
Member Author

The generated bower.json seems like the easiest way to keep supporting bower while also frequently testing with the latest package set.

@hdgarrood
Copy link
Contributor

There isn't really a "correct" approach that everyone agrees on right now, unfortunately. Hopefully this will become clearer once the registry work is a bit further along. As I say though, I think checking in a generated bower.json is fine, but I think it would be better to either exercise it directly in CI (i.e. via bower install and then checking the library can be compiled with pulp), or at least to verify in CI that running the spago command to regenerate bower.json doesn't result in changes. Preferably both?

@megamaddu
Copy link
Member Author

Makes sense, I'll add those

@megamaddu megamaddu force-pushed the madeline/spago branch 4 times, most recently from e5a35fa to 5433ee4 Compare March 5, 2021 22:05
@megamaddu megamaddu merged commit af7840b into main Mar 5, 2021
@megamaddu megamaddu deleted the madeline/spago branch March 5, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants