Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the _aria prop from being an Object to inline props #46

Open
i-am-the-slime opened this issue Jul 9, 2022 · 1 comment
Open

Comments

@i-am-the-slime
Copy link
Member

I think I had mentioned this in the past and if memory serves well @megamaddu concurred:

aria attributes are being handled like data attributes. That is, one can supply an Object String as _aria to most (all?) basic components and they will be correctly injected.
But contrary to data- attributes, the set of valid aria- attributes is well-defined and not free for the author to choose.

As a reference: Here's the list:

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes

@mjrussell
Copy link
Member

Sounds like a good improvement. I was wondering if any other purescript libraries had done this already or if there might be a small JS library that we could import all the names from. I don't see one unfortunately though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants