Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global CSS #4

Open
paf31 opened this issue Apr 16, 2019 · 2 comments
Open

Remove global CSS #4

paf31 opened this issue Apr 16, 2019 · 2 comments
Labels
planned API change Things we intend to break soon

Comments

@paf31
Copy link

paf31 commented Apr 16, 2019

  • the CSS should generate unique class names to prevent possible conflicts with UI elements that aren't a part of this library
  • should be more type safe, both in style definition and the attaching of styles to components
@paf31 paf31 added the planned API change Things we intend to break soon label Apr 19, 2019
@dwhitney
Copy link

I like what you guys are doing with JSS. What do you think about peeling it off into a separate library?

@megamaddu
Copy link
Member

megamaddu commented Jun 21, 2019

I think that'd be great, though it's very very rough at the moment. The current implementation is essentially just an unsafeCoerce, which probably doesn't merit its own library.

I'd like to figure out a better means of applying types to both the definitions and the way it's attached to DOM elements. That overlaps a lot with the efforts in https://github.com/dwhitney/purescript-react-basic-native though, and it might be easier to integrate with React as Styled-Components/Emotion types..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
planned API change Things we intend to break soon
Projects
None yet
Development

No branches or pull requests

3 participants