Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming a Table component doesn't reset its state (i.e. like key) #38

Open
megamaddu opened this issue May 26, 2019 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@megamaddu
Copy link
Member

This is rarely a problem because tables tend to be contained by other unique component instances (like pages), but as we move from manual component creation to DSLs and helper functions it's likely we'll end up with two pages with the same component structure. This could prevent React from remounting these components leading to issues with stale component state. For coincidences like these it might be a good idea to have the Table component reset itself when its identifying name changes to prevent mixing up localStorage data.

@megamaddu megamaddu added the bug Something isn't working label May 26, 2019
@megamaddu megamaddu self-assigned this May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant