Skip to content

Fix encoding #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 1, 2021
Merged

Fix encoding #9

merged 4 commits into from
Apr 1, 2021

Conversation

i-am-the-slime
Copy link
Contributor

@i-am-the-slime i-am-the-slime commented Mar 18, 2021 •
edited
Loading

Description of the change

Turns the PureScript Encoding type into the correct string that nodejs expects.

This avoids the following error.

TypeError [ERR_UNKNOWN_ENCODING]: Unknown encoding: UTF8 {}

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

hdgarrood
hdgarrood approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@hdgarrood hdgarrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

thomashoneyman
thomashoneyman approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @i-am-the-slime! Can you please add this to the changelog?

@i-am-the-slime
Fix encoding
b4efc12 
Otherwise I get:
```
TypeError [ERR_UNKNOWN_ENCODING]: Unknown encoding: UTF8 {}
```
@i-am-the-slime
Copy link
Contributor Author

@thomashoneyman I wrote a sentence. I hope it's more or less understandable.

@thomashoneyman thomashoneyman merged commit 15adf15 into purescript-node:master Apr 1, 2021
@thomashoneyman
Copy link
Contributor

https://github.com/purescript-node/purescript-node-net/releases/tag/v2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdgarrood hdgarrood hdgarrood approved these changes

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@i-am-the-slime @thomashoneyman @hdgarrood