update 1.0.0 #15
Merged
update 1.0.0 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryogenian
force-pushed
the
halogen-1.0.0
branch
2 times, most recently
from
c9e8c4a to
ebb3095
Compare
|
@garyb please review |
garyb
requested changes
Feb 7, 2017
| @@ -64,8 +65,8 @@ style = | |||
| rights = concatMap $ foldMap singleton | |||
|
|
|||
| -- | Render a set of rules as a `style` element. | |||
| stylesheet ∷ ∀ p i. CSS → HTML p i | |||
| stylesheet ∷ ∀ p i. CSS → HC.HTML p i | |||
There was a problem hiding this comment.
We can use HTMLstyle from DOM.HTML.Indexed for the p here.
There was a problem hiding this comment.
Yeah, that was my initial intention. But Node and Leaf from Halogen.HTML.Elements are functions from Array (IProp _) now and this thing doesn't use any props
src/Halogen/HTML/CSS.purs
Outdated
| style = | ||
| prop (propName "style") (Just $ attrName "style") | ||
| HP.prop (HC.PropName "style") |
There was a problem hiding this comment.
Instead of setting up a new prop and creating a IsProp instance for Styles I think we may as well reuse HP.style and compose in a function to print the CSS as a string. We can get rid of the Styles newtype then too, which was only there for the IsProp machinery.
cryogenian
force-pushed
the
halogen-1.0.0
branch
from
ebb3095 to
71a887d
Compare
|
garyb
approved these changes
Feb 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.