Fix HugeNum comparison #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomashoneyman
approved these changes
Nov 2, 2020
Comment on lines
+66
to
+70
| toFromNumIsIdentity :: Number -> Boolean | ||
| toFromNumIsIdentity n = HN.toNumber (HN.fromNumber n) == n | ||
|
|
||
| toFromIntIsIdentity :: Int -> Boolean | ||
| toFromIntIsIdentity n = HI.toInt (HI.fromInt n) == Just n |
There was a problem hiding this comment.
Thanks for adding these tests! Do these fail without the change you added?
There was a problem hiding this comment.
I think only the Int one fails.
Comment on lines
+105
to
+106
| | r1.decimal > r2.decimal = if r1.sign == Minus then LT else GT | ||
| | r1.decimal < r2.decimal = if r1.sign == Minus then GT else LT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR fixes comparing negative numbers. This was also causing the problem mentioned in #10 because
HugeInt.toIntwas usingHugeNumcomparison internally.Checklist:
Updated or added relevant documentation in the README and/or documentation directory