Skip to content

feat: add MonadAsk & MonadReader instances #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 20, 2022
Merged

feat: add MonadAsk & MonadReader instances #208

merged 5 commits into from
Oct 20, 2022

Conversation

bentongxyz
Copy link
Contributor

@bentongxyz bentongxyz commented Oct 15, 2022 •
edited
Loading

Description of the change

add MonadAsk & MonadReader instances

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

jamesdbrock
jamesdbrock approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@jamesdbrock jamesdbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

This looks correct to me, and I believe those instances can be very useful for ParserT. I'll leave the PR open for a few days to see if anyone else has an opinion.

natefaubion
natefaubion reviewed Oct 17, 2022
View reviewed changes
natefaubion
natefaubion reviewed Oct 17, 2022
View reviewed changes
bentongxyz and others added 3 commits October 18, 2022 22:15
@bentongxyz @natefaubion
Update src/Parsing.purs
da028c3 
Co-authored-by: Nathan Faubion <natefaubion@users.noreply.github.com>
@bentongxyz @jamesdbrock
Update src/Parsing.purs
3af7a3f 
Co-authored-by: James Brock <jamesbrock@gmail.com>
@bentongxyz
fix: remove unnecessary constraint
34c2dc3
@jamesdbrock jamesdbrock merged commit f59a383 into purescript-contrib:main Oct 20, 2022
@jamesdbrock
Copy link
Member

Thanks @bentongxyz !

@bentongxyz
Copy link
Contributor Author

@jamesdbrock a joy to code on Purescript and this parsing library thanks to you all amazing people behind them. I am just happy to contribute something useful back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natefaubion natefaubion natefaubion left review comments

@garyb garyb garyb approved these changes

@jamesdbrock jamesdbrock jamesdbrock approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bentongxyz @jamesdbrock @natefaubion @garyb