Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ch7 add tests and solutions #109

Closed
milesfrain opened this issue Apr 25, 2020 · 4 comments
Closed

ch7 add tests and solutions #109

milesfrain opened this issue Apr 25, 2020 · 4 comments
Assignees

Comments

@milesfrain
Copy link
Member

No description provided.

@oldfartdeveloper
Copy link

I'd like to do this one.

@milesfrain
Copy link
Member Author

Heads-up that #127 also touched parts of ch7. I don't think it will directly affect the work you're doing, but it may be wise to rebase sooner than later to avoid merge conflicts.

git pull --rebase upstream master

Assuming git remote -v shows something like this:

git remote -v
upstream        https://github.com/purescript-contrib/purescript-book.git (fetch)
upstream        https://github.com/purescript-contrib/purescript-book.git (push)

You can add an upstream with:

git remote add upstream https://github.com/purescript-contrib/purescript-book.git

@oldfartdeveloper
Copy link

oldfartdeveloper commented May 1, 2020

@milesfrain Thanks; I've been rebasing and, indeed, have had the identical remote upstream defined. I'm almost certain that #127 will affect the upcoming exercises, so I merged it; thanks for the heads-up.

@oldfartdeveloper
Copy link

@milesfrain I'm replacing PR #126 with this new one #146. #126 swept too many files into it; just easier to close that one and submit this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants