-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Fix issues with uploading binaries #261
base: develop
Are you sure you want to change the base?
Conversation
Problem 3 is fixed, waiting for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I forgot to test at this meeting but usually before we push a change relating to hardware we have a second person test it out. I'll do that at next meeting and approve.
analytics.send("upload-terminal") | ||
from .terminal import terminal | ||
ctx.invoke(upload, **upload_kwargs) | ||
ctx.invoke(terminal, request_banner=False) | ||
ctx.invoke(terminal, request_banner=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add newline here
Summary:
Fixed the first two issues with #245
Motivation:
To fix upload options
References (optional):
Closes #245
Test Plan:
pros upload --target v5 --slot 1 hello-world.bin
have a binary called hello-world.bin in a directory with project.pros and it should upload successfullyrun the same command without a slot number
run the same command with
pros ut