-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coexistence with vertical-border display table slot? #29
Comments
This is a fiddly case. Your code probably ends up modifying My guess is that you can P.S. Perhaps prefer |
Well, in fact, the problem might be that sometimes your function runs in a context where it affects |
ie. (defun prettify-vertical-border (&optional dummy)
(ignore dummy)
(when buffer-display-table
(set-display-table-slot buffer-display-table 'vertical-border ?│)))
(unless window-system
(set-display-table-slot standard-display-table 'vertical-border ?│)
(add-hook 'window-configuration-change-hook
'prettify-vertical-border)) |
Even more than that, you should never have top-level code which is conditional upon |
I really appreciate the quick and thorough response — thanks! Unfortunately, that didn’t do the trick... What I have now: (defun prettify-vertical-border (&optional dummy)
(ignore dummy)
(when buffer-display-table
(set-display-table-slot buffer-display-table 'vertical-border ?│)))
(when (not window-system)
(set-display-table-slot standard-display-table 'vertical-border ?│)
(add-hook 'window-configuration-change-hook 'prettify-vertical-border)
(when (featurep 'page-break-lines)
(add-hook 'page-break-lines-mode-hook 'prettify-vertical-border))) (I like the semantics of “when there’s not this, do this” vs “unless there’s this, do this”; it feels more like natural language, wheras I'd only say “unless” after the condition, “do this unless this.”) What seems especially odd is that this is only happening with windows spawned with modes derived from special-mode; if I open a dired buffer in the right window then I’ve asked the emacs-devel list if we can have Also, thanks for the hint re |
I imagine this is an issue with hook orders. What are the contents of |
Ah sorry I should have mentioned that I did try reordering the hooks and did get the same results; with the code above, evaluating
Then once adding the
So even when the Another tidbit of possibly useful info: after interacting with the minibuffer (e.g. |
Dear Steve,
In console Emacs, given that in many fonts the
|
vertical line character does not create a solid vertical line between line breaks, I’ve added the below code to my init to make the window vertical border a solid line.But I’ve found that this seems to conflict with global-page-break-lines-mode, and so when spawning a new window that creates a vertical split (with global-page-break-lines-mode enabled), I get the ugly old broken vertical border, and not my prettified vertical border. Specifically this happens when spawning a help-mode window on the left (i.e. from the right window).
I’m not entirely sure if root of this troubled coexistence lies with page-break-lines, given that I can only manifest the appearance of the old, broken vertical border when spawning a help-mode window (and with global-page-break-lines-mode) with
C-h o SYMBOL RET
.Please help! I don’t think I can live without the aesthetic soothingness of a solid vertical border and solid page-break-lines!
Many thanks.
The text was updated successfully, but these errors were encountered: