Skip to content

Commit 54599e5

Browse files
author
Puranjay Jain
committed
infinity added for max notification
1 parent dfcb8e3 commit 54599e5

File tree

8 files changed

+19
-13
lines changed

8 files changed

+19
-13
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,6 @@
1515
## v0.3.1
1616
* Fixed left icon prop being passed empty resulted in an error
1717
* Fixed left icon padding
18+
19+
## v0.3.2
20+
* Changed max notification count to infinity and allowed values are natural numbers or Infinity

build/app.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41657,7 +41657,7 @@ ReactMaterialUiNotifications.propTypes = {
4165741657
/**
4165841658
* maximum number of notifications to display
4165941659
*/
41660-
maxNotifications: _react.PropTypes.number,
41660+
maxNotifications: _react2.default.PropTypes.oneOfType([_react.PropTypes.string, _react.PropTypes.number]),
4166141661
/**
4166241662
* root component's style
4166341663
*/
@@ -41672,7 +41672,7 @@ ReactMaterialUiNotifications.propTypes = {
4167241672
transitionLeaveTimeout: _react.PropTypes.number
4167341673
};
4167441674
ReactMaterialUiNotifications.defaultProps = {
41675-
maxNotifications: 3,
41675+
maxNotifications: Infinity,
4167641676
rootStyle: {
4167741677
bottom: 20,
4167841678
right: 25
@@ -42123,8 +42123,8 @@ var ComponentData = [{
4212342123
description: 'Desktop device or touch device, in Desktop mode you have close button on the right'
4212442124
}, {
4212542125
prop: 'maxNotifications',
42126-
types: 'number',
42127-
default: 3,
42126+
types: 'number, string',
42127+
default: 'Infinity',
4212842128
description: 'Maximum number of notifications to display'
4212942129
}, {
4213042130
prop: 'rootStyle',

build/app.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/ReactMaterialUiNotifications.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ ReactMaterialUiNotifications.propTypes = {
184184
/**
185185
* maximum number of notifications to display
186186
*/
187-
maxNotifications: _react.PropTypes.number,
187+
maxNotifications: _react2.default.PropTypes.oneOfType([_react.PropTypes.string, _react.PropTypes.number]),
188188
/**
189189
* root component's style
190190
*/
@@ -199,7 +199,7 @@ ReactMaterialUiNotifications.propTypes = {
199199
transitionLeaveTimeout: _react.PropTypes.number
200200
};
201201
ReactMaterialUiNotifications.defaultProps = {
202-
maxNotifications: 3,
202+
maxNotifications: Infinity,
203203
rootStyle: {
204204
bottom: 20,
205205
right: 25

lib/ReactMaterialUiNotifications.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-materialui-notifications",
3-
"version": "0.3.1",
3+
"version": "0.3.2",
44
"description": "Spec compliant notifications for react and material ui users",
55
"keywords": [
66
"react",

src/app/ReactMaterialUiNotifications.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,10 @@ export default class ReactMaterialUiNotifications extends Component {
3030
/**
3131
* maximum number of notifications to display
3232
*/
33-
maxNotifications: PropTypes.number,
33+
maxNotifications: React.PropTypes.oneOfType([
34+
PropTypes.string,
35+
PropTypes.number
36+
]),
3437
/**
3538
* root component's style
3639
*/
@@ -49,7 +52,7 @@ export default class ReactMaterialUiNotifications extends Component {
4952
* default props
5053
*/
5154
static defaultProps = {
52-
maxNotifications: 3,
55+
maxNotifications: Infinity,
5356
rootStyle: {
5457
bottom: 20,
5558
right: 25

src/app/data.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ const ComponentData = [
1414
},
1515
{
1616
prop: 'maxNotifications',
17-
types: 'number',
18-
default: 3,
17+
types: 'number, string',
18+
default: 'Infinity',
1919
description: 'Maximum number of notifications to display'
2020
},
2121
{

0 commit comments

Comments
 (0)