Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing colon between hour and minute in 24-hour format #56

Closed
db-dblank opened this issue May 24, 2016 · 4 comments
Closed

Missing colon between hour and minute in 24-hour format #56

db-dblank opened this issue May 24, 2016 · 4 comments

Comments

@db-dblank
Copy link

missing-colon

@db-dblank db-dblank changed the title Missing colon between hour and minute in 24 hour format Missing colon between hour and minute in 24-hour format May 24, 2016
@puranjayjain
Copy link
Owner

@db-dblank it is deliberately not being put there since in 24 hour modes you don't essentially put a colon between the values e.g 2400 hours or 1200 hours etc. Similar to the military way of putting the time.

Also, to differentiate between the 24 hour mode and the 12 hour mode.Also, the material design spec is not very clear on this matter.
Although I might implement this if you can provide me with a strong reference.

@db-dblank
Copy link
Author

Hi @puranjayjain,

All my apps on Android has the colon between hour and minute, see the Google Calendar app:

calendar-timepicker

Or, add an argument to show or hide de colon.

Thanks.

@puranjayjain
Copy link
Owner

@db-dblank I'll add the option for it to be configurable that doesn't hurt anybody 😄

@puranjayjain
Copy link
Owner

Contradicting to my original statement.This option should indeed be default and not opt-in and hence colon should be true by default. (removal is not an option until v3.0.0 since this can have breaking changes).

https://www.google.com/design/spec/patterns/data-formats.html#data-formats-date-time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants