Get pool data however the state (resp. status) #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
samy-mahmoudi
force-pushed
the
fix-provider-zpool-according-to-the-variety-of-states-and-statuses
branch
4 times, most recently
from
983c294 to
7621c23
Compare
johro81
reviewed
Jan 19, 2023
lib/puppet/provider/zpool/zpool.rb
Outdated
| zpool_data = out.lines.select { |line| line.index("\t") == 0 }.map { |l| l.strip.split("\s")[0] } | ||
| zpool_data.shift | ||
| out = execute("zpool iostat -v #{zpool_opts} #{@resource[:pool]}", failonfail: false, combine: false) | ||
| zpool_data = out.lines[3..-2].map { |line| line.strip.split("\s")[0] } |
There was a problem hiding this comment.
This fails on Solaris 11 since the last separator is included because of an empty line at the end of the command.
This commits substitutes 'zpool iostat' for 'zpool status' to fix improper parsing due to the variety of states and statuses.
samy-mahmoudi
force-pushed
the
fix-provider-zpool-according-to-the-variety-of-states-and-statuses
branch
from
7621c23 to
c070269
Compare
johro81
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit substitutes 'zpool iostat' for 'zpool status' to fix improper parsing due to the variety of states and statuses.