Merge pull request #206 from david22swan/BUGFIX/main/remove_validate_legacy

(CONT-967) Replace all uses of validate_*() with assert_type()

Author: jordanbreen28

manifests/init.pp

@@ -162,8 +162,6 @@
 
   $_au_base = "${_basekey}\\AU"
 
-  validate_legacy(Boolean, 'validate_bool', $purge_values)
-
   registry_key { $_basekey:
     ensure       => present,
     purge_values => $purge_values,
@@ -190,14 +188,14 @@
       has_enabled => false,
     }
     if $server_url {
-      validate_legacy(Optional[Variant[Stdlib::HTTPUrl,Boolean]],'validate_re' ,$server_url, '^http(|s):\/\/', "server_url is required to be either http or https, ${server_url}")
+      assert_type(Stdlib::HTTPUrl, $server_url)
       wsus_client::setting { "${_basekey}\\WUServer":
         type        => 'string',
         data        => $server_url,
         has_enabled => false,
       }
       if $enable_status_server != undef {
-        validate_legacy(Boolean, 'validate_bool', $enable_status_server)
+        assert_type(Boolean, $enable_status_server)
         $_ensure_status_server = $enable_status_server ? {
           true => 'present',
           false => 'absent',

manifests/setting.pp

@@ -45,7 +45,7 @@
         validate_in_range($data,$validate_range[0],$validate_range[1])
       }
       if $validate_bool {
-        validate_legacy(Boolean, 'validate_bool', $data)
+        assert_type(Boolean, $data)
       }
       $_data = $validate_bool ? {
         true => bool2num($data),