Correct casing of Stdlib::IP::Address #1406
Conversation
While Puppet doesn't appear to care about IP vs Ip, but Kafo does and can't find the correct type. This aligns the usage with the actual name in the file. Fixes: fcbd426 ("Remove deprecated Stdlib::Compat::* data types")
ekohl
requested review from
alexjfisher,
b4ldr,
bastelfreak,
smortex,
seanmil and
a team
as code owners
| @@ -1,2 +1,2 @@ | |||
| # @summary Validate a host (FQDN or IP address) | |||
| type Stdlib::Host = Variant[Stdlib::Fqdn, Stdlib::Ip::Address] | |||
| type Stdlib::Host = Variant[Stdlib::Fqdn, Stdlib::IP::Address] | |||
There was a problem hiding this comment.
This now matches the casing here:
puppetlabs-stdlib/types/ip/address.pp
Line 2 in 883ba57
There was a problem hiding this comment.
Interesting 🤔. For some reason I stick to \A[[:upper:]][[:lower:]]*\z but it seems having more capital letters is valid… I guess what annoyed me is that I wanted to camel_case the type name for the file name as we do with Ruby but this is not supported…
There was a problem hiding this comment.
I agree that IP is a bit unusual, but this has been here for a while and sometimes being consistent is more important than other preferences.
|
I think the test failures are unrelated |
| @@ -1,2 +1,2 @@ | |||
| # @summary Validate a host (FQDN or IP address) | |||
| type Stdlib::Host = Variant[Stdlib::Fqdn, Stdlib::Ip::Address] | |||
| type Stdlib::Host = Variant[Stdlib::Fqdn, Stdlib::IP::Address] | |||
There was a problem hiding this comment.
Interesting 🤔. For some reason I stick to \A[[:upper:]][[:lower:]]*\z but it seems having more capital letters is valid… I guess what annoyed me is that I wanted to camel_case the type name for the file name as we do with Ruby but this is not supported…
|
restarted failed jobs. |
While Puppet doesn't appear to care about IP vs Ip, but Kafo does and can't find the correct type. This aligns the usage with the actual name in the file.
Fixes: fcbd426 ("Remove deprecated Stdlib::Compat::* data types")