Skip to content

(CONT-1023) - Moving nested_values function under stdlib namespace #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2023
Merged

(CONT-1023) - Moving nested_values function under stdlib namespace #1363

merged 1 commit into from
Jun 1, 2023

Conversation

Ramesh7
Copy link
Contributor

@Ramesh7 Ramesh7 commented May 31, 2023

Addressing review comments of #1359

@Ramesh7 Ramesh7 changed the title (CONT-1023) - Addressing review comments (CONT-1023) - Moving nested_values function under stdlib namespace May 31, 2023
@Ramesh7 Ramesh7 force-pushed the CONT-1023-review-comments branch from c47d704 to ddb1e31 Compare May 31, 2023 08:33
@Ramesh7 Ramesh7 mentioned this pull request May 31, 2023
Merged
@alexjfisher
Copy link
Collaborator

Great! It might also be worth adding @param tags and regenerating the REFERENCE.md to check it renders nicely.

alexjfisher
alexjfisher reviewed May 31, 2023
View reviewed changes
alexjfisher
alexjfisher reviewed May 31, 2023
View reviewed changes
alexjfisher
alexjfisher reviewed May 31, 2023
View reviewed changes
@Ramesh7 Ramesh7 force-pushed the CONT-1023-review-comments branch 3 times, most recently from 8b61d77 to 4bbf0a2 Compare May 31, 2023 10:12
alexjfisher
alexjfisher reviewed May 31, 2023
View reviewed changes
@Ramesh7 Ramesh7 force-pushed the CONT-1023-review-comments branch from b0b8e61 to ef19ca3 Compare May 31, 2023 14:57
binford2k
binford2k previously approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@binford2k binford2k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Adding the @param tags that I was lazy and forgot to do initially is a good idea also.

alexjfisher
alexjfisher reviewed Jun 1, 2023
View reviewed changes
@alexjfisher
Copy link
Collaborator

@Ramesh7 Cool. Thanks for the touchups. I think this is good to go now. Would you like to squash your commits first?

smortex
smortex approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ramesh7 Ramesh7 force-pushed the CONT-1023-review-comments branch from 8abe016 to b225099 Compare June 1, 2023 17:39
@alexjfisher alexjfisher merged commit f38c42a into main Jun 1, 2023
@alexjfisher alexjfisher deleted the CONT-1023-review-comments branch June 1, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjfisher alexjfisher alexjfisher approved these changes

@smortex smortex smortex approved these changes

@binford2k binford2k binford2k left review comments

@b4ldr b4ldr Awaiting requested review from b4ldr b4ldr is a code owner

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

@ekohl ekohl Awaiting requested review from ekohl ekohl is a code owner

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ramesh7 @alexjfisher @smortex @binford2k @jordanbreen28