Skip to content

Rewrite validate_email_address() as a Puppet 4.x function #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2023

Conversation

smortex
Copy link
Collaborator

@smortex smortex commented May 4, 2023

The 3.x function rely on is_email_address() which is deprecated. Rewrite it using the more modern puppet 4.x function to rely on data types for better parameters validation.

@smortex smortex requested review from a team, alexjfisher, b4ldr, bastelfreak and ekohl as code owners May 4, 2023 19:32
@puppet-community-rangefinder
Copy link

validate_email_address is a function

that may have no external impact to Forge modules.

validate_email_address is a function

that may have no external impact to Forge modules.

This module is declared in 318 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

The 3.x function rely on is_email_address() which is deprecated. Rewrite
it using the more modern puppet 4.x function to rely on data types for
better parameters validation.
@smortex smortex force-pushed the validate_email_address branch from f00cb4f to b4602ac Compare May 4, 2023 21:04
@b4ldr b4ldr merged commit d279eac into main May 8, 2023
@b4ldr b4ldr deleted the validate_email_address branch May 8, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants