Skip to content

Allow deferrable_epp to return a Sensitive[String] #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2023

Conversation

alexjfisher
Copy link
Collaborator

If none of the input variables are Deferred, then deferrable_epp returns the result of calling normal epp.

The epp function however will return a Sensitive if any of the variables it was called with were Sensitive.

See puppetlabs/puppet#8330

Adding Sensitive[String] to the list of allowed return types fixes this.

If none of the input variables are `Deferred`, then `deferrable_epp`
returns the result of calling normal `epp`.

The `epp` function however will return a `Sensitive` if any of the
variables it was called with were `Sensitive`.

See puppetlabs/puppet#8330

Adding `Sensitive[String]` to the list of allowed return types fixes
this.
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit bdf14f5 into puppetlabs:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants