Remove dig and dig44 functions

[MartyEwings]

dig became part of puppet core in Puppet 4, and even the compatibility function dig44 does not work in puppet 6 or later

this should be removed.

As part of this PR try_get_value was also removed as it was deprecated in favour of dig 6 years ago

[puppet-community-rangefinder]

dig is a function

Breaking changes to this file MAY impact these 74 modules (near match):

• KyleAnderson-consul
• puppet-telegraf
• puppetlabs-puppet_metrics_dashboard
• puppetlabs-puppet_metrics_collector
• puppet-firewalld
• enterprisemodules-ora_install
• sensu-sensuclassic
• oxc-dovecot
• pltraining-classroom
• simp-auditd
• enterprisemodules-wls_install
• codingfuture-cfsystem
• zleslie-ssh
• simp-sssd
• codingfuture-cfdb
• simp-polkit
• geoffwilliams-r_profile
• simp-simp
• enterprisemodules-mq_install
• simp-pupmod
• osc-openondemand
• treydock-infiniband
• treydock-globus
• simp-selinux
• codingfuture-cfweb
• crowdstrike-falcon
• puppetlabs-pe_databases
• simp-simp_openldap
• treydock-kdump
• deric-beegfs
• treydock-oxidized
• geoffwilliams-system_users
• fraenki-acme
• ULHPC-slurm
• treydock-mofed
• ploperations-account
• simp-gdm
• bzed-dehydrated
• simp-resolv
• treydock-osg
• simp-crypto_policy
• simp-network
• treydock-perfsonar
• codingfuture-cfwebapp
• simp-simp_gitlab
• maxadamo-tiny_nas
• geoffwilliams-aix_tidy
• treydock-clustershell
• treydock-gpfs
• oxc-postfix
• geoffwilliams-jruby
• pltraining-classroom_legacy
• treydock-slurm
• puppet-consul
• geoffwilliams-redhat_tidy
• puppetlabs-dropsonde
• southalc-vault_secrets
• opuscodium-odoo
• simp-simp_firewalld
• treydock-powerman
• enterprisemodules-pg_secured
• treydock-genders
• ploperations-ssh
• tomkrieger-security_baseline
• helio-fluentbit
• halyard-disks
• blockops-tailscale
• simp-ds389
• encore-ipa
• puppetlabs-data_entitlement
• enterprisemodules-db2_profile
• opuscodium-ssh
• enterprisemodules-db2_install
• enterprisemodules-mssql_secured

dig44 is a function

Breaking changes to this file MAY impact these 3 modules (near match):

• bibigon812-network
• openstack-swift
• jetstack-kubernetes

This module is declared in 318 of 580 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[MartyEwings]

Looks like some of the unit tests for Other functions used Dig? ill have to figure out how to unhook all of that

*** fixed*** 2 layers of functional deprecation in this one...

[bastelfreak]

I'm surprised that the REFERENCE.md wasn't updated. The CI probably doesn't check for it (we recently implemented. I don't think you need to regenerate it for each PR, but during the release PR we need to ensure it's up2date (puppetlabs_spec_helper has a rake task for that I think). CC: @chelnak

I think vox pupuli calls this: release_checks -> validate -> https://github.com/puppetlabs/puppetlabs_spec_helper/blob/main/lib/puppetlabs_spec_helper/rake_tasks.rb#L213

[MartyEwings]

I'm surprised that the REFERENCE.md wasn't updated. The CI probably doesn't check for it (we recently implemented. I don't think you need to regenerate it for each PR, but during the release PR we need to ensure it's up2date (puppetlabs_spec_helper has a rake task for that I think). CC: @chelnak

I think vox pupuli calls this: release_checks -> validate -> https://github.com/puppetlabs/puppetlabs_spec_helper/blob/main/lib/puppetlabs_spec_helper/rake_tasks.rb#L213

I think if this is the same as my workflows on my team, REFERENCE.MD is updated as part of the release prep workflow

[chelnak]

Yeah I believe that is correct

[LukasAud]

LGTM