Skip to content

Remove Puppet 5.5 deprecations #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2023
Merged

Remove Puppet 5.5 deprecations #1314

merged 1 commit into from
Apr 24, 2023

Conversation

MartyEwings
Copy link
Contributor

as noted in this PR #896

as of Puppet 5.5 these functions have been available in core puppet and should now be removed

@puppet-community-rangefinder
Copy link

length is a function

Breaking changes to this file MAY impact these 61 modules (near match):

empty is a function

Breaking changes to this file MAY impact these 483 modules (near match):

flatten is a function

Breaking changes to this file MAY impact these 129 modules (near match):

join is a function

Breaking changes to this file MAY impact these 655 modules (near match):

keys is a function

Breaking changes to this file MAY impact these 175 modules (near match):

values is a function

Breaking changes to this file MAY impact these 23 modules (near match):

This module is declared in 318 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

LukasAud
LukasAud approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, these also look like they can be removed right away. LGTM

@LukasAud LukasAud merged commit 5bdbf12 into puppetlabs:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

@LukasAud LukasAud LukasAud approved these changes

@alexjfisher alexjfisher Awaiting requested review from alexjfisher alexjfisher is a code owner

@b4ldr b4ldr Awaiting requested review from b4ldr b4ldr is a code owner

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

@ekohl ekohl Awaiting requested review from ekohl ekohl is a code owner

@smortex smortex Awaiting requested review from smortex smortex is a code owner

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartyEwings @david22swan @LukasAud