(CONT-1023) - Addressing review comments

Author: Ramesh7

functions/deferrable_epp.pp

@@ -6,7 +6,7 @@
 # have to explicitly pass the entire scope to the client.
 #
 function stdlib::deferrable_epp(String $template, Hash $variables) >> Variant[String, Sensitive[String], Deferred] {
-  if $variables.nested_values.any |$value| { $value.is_a(Deferred) } {
+  if $variables.stdlib::nested_values.any |$value| { $value.is_a(Deferred) } {
     Deferred(
       'inline_epp',
       [find_template($template).file, $variables],

lib/puppet/functions/nested_values.rb renamed to lib/puppet/functions/stdlib/nested_values.rb

@@ -1,18 +1,17 @@
 # frozen_string_literal: true
 
 # This function will return list of Hash values, the return value will be Array
-# NOTE : This function is expecting only Hash and return value will be Array
 #
 # @example :
 # $hash = {
 #   "key1" => "value1",
 #   "key2" => { "key2.1" => "value2.1"}
 # }
-# $hash.nested_values
+# $hash.stdlib::nested_values
 #
 # Output : ["value1", "value2.1"]
 #
-Puppet::Functions.create_function(:nested_values) do
+Puppet::Functions.create_function(:'stdlib::nested_values') do
   dispatch :nested_values do
     param 'Hash', :options
     return_type 'Array'

spec/functions/nested_values_spec.rb

@@ -2,10 +2,7 @@
 
 require 'spec_helper'
 
-describe 'nested_values' do
-  # please note that these tests are examples only
-  # you will need to replace the params and return value
-  # with your expectations
+describe 'stdlib::nested_values' do
   it { is_expected.to run.with_params({}).and_return([]) }
   it { is_expected.to run.with_params({ 'key' => 'value' }).and_return(['value']) }
   it { is_expected.to run.with_params({ 'key' => { 'key1' => 'value1', 'key2' => 'value2' } }).and_return(['value1', 'value2']) }