Addressing review comments

Author: Ramesh7

functions/deferrable_epp.pp

@@ -6,7 +6,7 @@
 # have to explicitly pass the entire scope to the client.
 #
 function stdlib::deferrable_epp(String $template, Hash $variables) >> Variant[String, Sensitive[String], Deferred] {
-  if $variables.hash_values.any |$value| { $value.is_a(Deferred) } {
+  if $variables.nested_values.any |$value| { $value.is_a(Deferred) } {
     Deferred(
       'inline_epp',
       [find_template($template).file, $variables],

lib/puppet/functions/hash_values.rb renamed to lib/puppet/functions/nested_values.rb

@@ -8,19 +8,19 @@
 #   "key1" => "value1",
 #   "key2" => { "key2.1" => "value2.1"}
 # }
-# $hash.hash_value
+# $hash.nested_values
 #
 # Output : ["value1", "value2.1"]
 #
-Puppet::Functions.create_function(:hash_values) do
-  dispatch :hash_values do
+Puppet::Functions.create_function(:nested_values) do
+  dispatch :nested_values do
     param 'Hash', :options
     return_type 'Array'
   end
 
-  def hash_values(options)
+  def nested_values(options)
     options.each_with_object([]) do |(_k, v), values|
-      v.is_a?(Hash) ? values.concat(hash_values(v)) : (values << v)
+      v.is_a?(Hash) ? values.concat(nested_values(v)) : (values << v)
     end
   end
 end

spec/functions/hash_values_spec.rb renamed to spec/functions/nested_values_spec.rb

@@ -2,13 +2,14 @@
 
 require 'spec_helper'
 
-describe 'hash_values' do
+describe 'nested_values' do
   # please note that these tests are examples only
   # you will need to replace the params and return value
   # with your expectations
   it { is_expected.to run.with_params({}).and_return([]) }
   it { is_expected.to run.with_params({ 'key' => 'value' }).and_return(['value']) }
   it { is_expected.to run.with_params({ 'key' => { 'key1' => 'value1', 'key2' => 'value2' } }).and_return(['value1', 'value2']) }
+  it { is_expected.to run.with_params({ 'key1' => 'value1', 'key2' => { 'key1' => 'value21', 'key2' => 'value22' }, 'key3' => 'value3' }).and_return(['value1', 'value21', 'value22', 'value3']) }
   it { is_expected.to run.with_params(2).and_raise_error(StandardError) }
   it { is_expected.to run.with_params(nil).and_raise_error(StandardError) }
 end