Fix the non-defaults test failing to use UTF8 #194
Conversation
The non-default tests try to set UTF8 when UTF8 is not installed on the en_US machine. These are non-default settings anyway, but one should presume the correct locale should be set before this is attempted, this patch includes that step. In an ideal world we would use a locale module to do this. This patch also fixes an Ubuntu 10.04 issue where you need to be absolute about the locale and encoding as well. Signed-off-by: Ken Barber <ken@bob.sh>
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-postgresql/45/) |
|
Merged build finished. (Status: FAILURE, Details: http://box.bob.sh:8080/job/puppetlabs-postgresql/45/) |
|
retest this please |
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-postgresql/47/) |
|
Merged build finished. (Status: SUCCESS, Details: http://box.bob.sh:8080/job/puppetlabs-postgresql/47/) |
| # Need to make sure the correct utf8 locale is ready for our | ||
| # non-standard tests | ||
| file { '/etc/locale.gen': | ||
| content => "en_US ISO-8859-1\nen_NG UTF-8\nen_US UTF-8\n", |
There was a problem hiding this comment.
Is it intentional that en_US appears twice in this list?
There was a problem hiding this comment.
I guess that just means you're wanting to support two different encodings for en_US? Is there a reason why you need the ISO one?
There was a problem hiding this comment.
I guess my thought was to preserve the default encoding on the box (en_US ISO-8859-1) to avoid complicating things and introducing any other weirdness. This ISO one is so the locale specific setting later on works (line 45).
Fix the non-defaults test failing to use UTF8
The non-default tests try to set UTF8 when UTF8 is not installed on the en_US
machine. These are non-default settings anyway, but one should presume the
correct locale should be set before this is attempted, this patch includes
that step.
In an ideal world we would use a locale module to do this.
This patch also fixes an Ubuntu 10.04 issue where you need to be absolute about
the locale and encoding as well.
Signed-off-by: Ken Barber ken@bob.sh