Skip to content

Add supprot for contrib package #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2013
Merged

Add supprot for contrib package #135

merged 2 commits into from
Mar 5, 2013

Conversation

kamilszymanski
Copy link
Contributor

No description provided.

@kbarber
Copy link
Contributor

kbarber commented Mar 1, 2013

This needs rebasing. Also:

  • can you add the class documentation to README.md?
  • the parameter will need to be reflected in init.pp for global override
  • a very basic rspec test to make sure it continues to compile would be appreciated

Thanks!

@kamilszymanski
Copy link
Contributor Author

Fixed, updated & rebased.
Thanks for the review.

kbarber added a commit that referenced this pull request Mar 5, 2013
@kbarber
Merge pull request #135 from kamilszymanski/contrib
572f090 
Add supprot for contrib package
@kbarber kbarber merged commit 572f090 into puppetlabs:master Mar 5, 2013
@kamilszymanski kamilszymanski deleted the contrib branch September 23, 2013 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamilszymanski @kbarber @Ramesh7