Skip to content

[IAC-1735] Fix test suite #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 16, 2021
Merged

[IAC-1735] Fix test suite #1291

merged 2 commits into from
Aug 16, 2021

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Aug 15, 2021 •
edited by adrianiurca
Loading

Continuation of #1289. Individual commits have more details.
Closes: #1289

@adrianiurca @ekohl
Reflect change of default in ensure_packages
c8303fd 
puppetlabs/puppetlabs-stdlib@77a9c07
changed the default for ensure_packages() in stdlib. This change updates
the tests to match that default change.
@ekohl ekohl requested a review from a team as a code owner August 15, 2021 18:32
@ekohl ekohl mentioned this pull request Aug 15, 2021
Closed
@smortex
Copy link
Collaborator

smortex commented Aug 15, 2021

We needs one more let(:postgresql_version) { '9.6' } to replace the condition that trigger the error.

@ekohl
Copy link
Collaborator Author

ekohl commented Aug 15, 2021

I wish PDK actually worked on Ruby 3 so I could run things locally.

@ekohl
Remove use of spec_helper_acceptance in unit tests
fc01e83 
In c96b073 the acceptance helper was
included in the unit tests. This should never happen and breaks the
tests. It appears it was included to have a postgresql_version but that
should be defined in let blocks. The acceptance helper only works if
there is an actual target machine.

Fixes: c96b073
@ekohl
Copy link
Collaborator Author

ekohl commented Aug 16, 2021

Looks like CentOS 8 timed out but this doesn't really touch acceptance tests so shall we merge this? I'm hesitant to merge my own PRs.

@bastelfreak bastelfreak merged commit 09b242a into puppetlabs:main Aug 16, 2021
@bastelfreak
Copy link
Collaborator

merging this since it only fixes the CI pipeline and unblocks other PRs.

@ekohl ekohl mentioned this pull request Aug 16, 2021
Merged
@ekohl ekohl deleted the fix-tests branch August 16, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjfisher alexjfisher alexjfisher approved these changes

@smortex smortex smortex approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ekohl @smortex @bastelfreak @alexjfisher @adrianiurca