Skip to content

node_group type: Allow uppercase letters in environment names #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

bastelfreak
Copy link
Contributor

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@bastelfreak bastelfreak requested a review from a team as a code owner September 16, 2024 13:50
@bastelfreak
Copy link
Contributor Author

bastelfreak commented Sep 16, 2024

I've customers that use jira issue keys, which are all uppercase, as environment names. This works fine since years, we just now want to configure them for some node groups.

@Ramesh7 Ramesh7 merged commit c7b66c3 into puppetlabs:main Sep 16, 2024
4 of 5 checks passed
bastelfreak pushed a commit to bastelfreak/puppet-node_manager that referenced this pull request Sep 16, 2024
node_group type: Allow uppercase letters in environment names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants