Skip to content

fix for issue #1502 #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix for issue #1502 #1503

wants to merge 4 commits into from

Conversation

o4ier
Copy link

@o4ier o4ier commented Oct 21, 2022

No description provided.

@o4ier o4ier requested a review from a team as a code owner October 21, 2022 08:20
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2022

CLA assistant check
All committers have signed the CLA.

@o4ier
Copy link
Author

o4ier commented Oct 21, 2022

Ok, "just a little change" means more I am afraid. I will go back and retry after following the contributing document.

@o4ier o4ier closed this Oct 21, 2022
* Even after issue puppetlabs#1474 we encounter changes of privileges each puppet run.
  This behavior is fixed by addition of another expanded privilege list
* fix trailing whitespaces
@o4ier o4ier reopened this Oct 24, 2022
o4ier added 2 commits October 24, 2022 14:41
* Even after issue puppetlabs#1474 we encounter changes of privileges each puppet run.
  This behavior is fixed by addition of another expanded privilege list
* fix validation errors
@david22swan
Copy link
Member

@o4ier Look' like your change is causing some test failures

@GSPatton
Copy link
Contributor

We are closing this PR due to inactivity. Feel free to reopen if you feel like working on it again. Thanks for your contribution.

@alaunay
Copy link

alaunay commented Nov 5, 2023

We're hit by this too. What's the status of the PR ?

@o4ier
Copy link
Author

o4ier commented Jan 21, 2024

Hello @alaunay
as mentioned by @GSPatton there are some issues with tests, that I am not "deep" enough in the whole process to fix.
Feel free to fork my code, fix the tests and open your own PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants