Release prep v11.0.0 #2464
Merged
Release prep v11.0.0 #2464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
bastelfreak,
ekohl,
smortex and
a team
as code owners
github-actions
bot
force-pushed
the
release-prep
branch
from
8d6af31 to
d80f349
Compare
ekohl
requested changes
Sep 21, 2023
github-actions
bot
force-pushed
the
release-prep
branch
from
d80f349 to
177616a
Compare
github-actions
bot
force-pushed
the
release-prep
branch
from
177616a to
a80c37a
Compare
Ramesh7
previously approved these changes
Sep 22, 2023
ekohl
requested changes
Sep 22, 2023
There was a problem hiding this comment.
Those were just some examples. There's still more deprecated code in the module:
$ rg -i depre manifests/ lib/
manifests/vhost.pp
1099:# > **Note**: This parameter is deprecated in favor of the `aliases` parameter.<br />
2705: deprecation('apache::vhost::wsgi_daemon_process_options', 'This parameter is deprecated. Please add values inside Hash `wsgi_daemon_process`.')
lib/puppet/functions/bool2httpd.rb
3:# @summary DEPRECATED. Use the namespaced function [`apache::bool2httpd`](#apachebool2httpd) instead.
5: dispatch :deprecation_gen do
8: def deprecation_gen(*args)
9: call_function('deprecation', 'bool2httpd', 'This function is deprecated, please use apache::bool2httpd instead.')
lib/puppet/functions/apache_pw_hash.rb
3:# @summary DEPRECATED. Use the namespaced function [`apache::pw_hash`](#apachepw_hash) instead.
5: dispatch :deprecation_gen do
8: def deprecation_gen(*args)
9: call_function('deprecation', 'apache_pw_hash', 'This function is deprecated, please use apache::pw_hash instead.')
manifests/init.pp
110:# determine an appropriate `content-type`. This directive is deprecated in Apache 2.4 and
429:# > **Note**: This parameter is deprecated in favor of the `purge_configs` parameter.<br />
602: # Deprecated backwards-compatibility
604: warning('Class[\'apache\'] parameter purge_vdir is deprecated in favor of purge_configs')
lib/puppet/functions/apache/apache_pw_hash.rb
3:# @summary DEPRECATED. Use the function [`apache::pw_hash`](#apachepw_hash) instead.
5: dispatch :deprecation_gen do
8: def deprecation_gen(*args)
9: call_function('deprecation', 'apache::apache_pw_hash', 'This function is deprecated, please use apache::pw_hash instead.')
manifests/mod/auth_cas.pp
25:# Whether to validate the presented certificate. This has been deprecated and
manifests/mod/remoteip.pp
16:# *Deprecated*: use `$internal_proxy` instead.
43:# *Deprecated*: use `$trusted_proxy` instead.
67: deprecation('apache::mod::remoteip::proxy_ips', 'This parameter is deprecated, please use `internal_proxy`.')
76: deprecation('apache::mod::remoteip::trusted_proxy_ips', 'This parameter is deprecated, please use `trusted_proxy`.')
manifests/mod/passenger.pp
263:# Deprecated in 3.0.0 in favor of PassengerBaseURI.
281:# Deprecated in 3.0.0 in favor of PassengerBaseURI.
284:# Deprecated in 3.0.0 in favor of PassengerDefaultUser
294:# Deprecated in 3.0.0 in favor of PassengerRuby.
297:# Deprecated in 3.0.0 in favor of PassengerSpawnMethod.
300:# Deprecated in 3.0.0 in favor of PassengerUserSwitching.
314:# The current set of server configurations settings were taken directly from the Passenger Reference. To enable deprecation warnings
318:# - As of 08/13/2017 there are 84 available/deprecated/removed settings.
320:# - As of 08/20/2017 there are 77 available/deprecated/removed settings.
480: warning('DEPRECATED PASSENGER OPTION :: passenger_debug_log_file :: This option has been renamed in version 5.0.5 to PassengerLogFile.')
778: warning('DEPRECATED PASSENGER OPTION :: rack_base_uri :: Deprecated in 3.0.0 in favor of PassengerBaseURI.')
788: warning("DEPRECATED PASSENGER OPTION :: rails_allow_mod_rewrite :: This option doesn't do anything anymore in since version 4.0.0.")
803: warning('DEPRECATED PASSENGER OPTION :: rails_base_uri :: Deprecated in 3.0.0 in favor of PassengerBaseURI.')
808: warning('DEPRECATED PASSENGER OPTION :: rails_default_user :: Deprecated in 3.0.0 in favor of PassengerDefaultUser.')
823: warning('DEPRECATED PASSENGER OPTION :: rails_ruby :: Deprecated in 3.0.0 in favor of PassengerRuby.')
828: warning('DEPRECATED PASSENGER OPTION :: rails_spawn_method :: Deprecated in 3.0.0 in favor of PassengerSpawnMethod.')
833: warning('DEPRECATED PASSENGER OPTION :: rails_user_switching :: Deprecated in 3.0.0 in favor of PassengerUserSwitching.')
912: # - $passenger_debug_log_file : since unkown. Deprecated in 5.0.5.
963: # - $passenger_use_global_queue : since 2.0.4.Deprecated in 4.0.0.
966: # - $rack_auto_detect : since unkown. Deprecated in 4.0.0.
967: # - $rack_base_uri : since unkown. Deprecated in 3.0.0.
969: # - $rails_allow_mod_rewrite : since unkown. Deprecated in 4.0.0.
970: # - $rails_app_spawner_idle_time : since unkown. Deprecated in 4.0.0.
971: # - $rails_auto_detect : since unkown. Deprecated in 4.0.0.
972: # - $rails_base_uri : since unkown. Deprecated in 3.0.0.
973: # - $rails_default_user : since unkown. Deprecated in 3.0.0.
975: # - $rails_framework_spawner_idle_time : since unkown. Deprecated in 4.0.0.
976: # - $rails_ruby : since unkown. Deprecated in 3.0.0.
977: # - $rails_spawn_method : since unkown. Deprecated in 3.0.0.
978: # - $rails_user_switching : since unkown. Deprecated in 3.0.0.
979: # - $wsgi_auto_detect : since unkown. Deprecated in 4.0.0.I'd look at Passenger and see what common minimum versions are these days. For example, there's still code for mod_passenger 0.x but I doubt that's still shipped anywhere.
@ekohl agreed, was going through today the deprication thing and we have long list for that, I thought to take that as new items and deliver those in upcoming releaes. |
|
@ekohl saying that I have created backlog items for tracking the same. |
|
I created #2469 for the scriptaliases parameter. |
|
Just now saw you already covered for scriptaliases. |
This was referenced Sep 22, 2023
Closed
github-actions
bot
force-pushed
the
release-prep
branch
from
a80c37a to
0529ab6
Compare
Ramesh7
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated release-prep through pdk-templates from commit 502a891.
Please verify before merging: