Skip to content

(CAT-1351) - Downgrading puppet-lint gem #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

(CAT-1351) - Downgrading puppet-lint gem #2445

wants to merge 1 commit into from

Conversation

Ramesh7
Copy link
Contributor

@Ramesh7 Ramesh7 commented Aug 29, 2023

Summary

Recently rolled-out puppet-lint gem checking title as well for unsafe interpolation which seems to be a issue with feature so, downgrading the gem version to avoid the unsafe interpolation issue for title.
Have reported the same to Team.

Additional Context

Add any additional context about the problem here.

Related Issues (if any)

  • N/A

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@Ramesh7 Ramesh7 requested review from bastelfreak, ekohl, smortex and a team as code owners August 29, 2023 13:24
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎 on this. In puppetlabs/puppet-lint#147 it's proposed to drop the check instead, which would avoid requiring to do updates everywhere.

@Ramesh7
Copy link
Contributor Author

Ramesh7 commented Aug 29, 2023

👎 on this. In puppetlabs/puppet-lint#147 it's proposed to drop the check instead, which would avoid requiring to do updates everywhere.

Thanks @ekohl, just now noticed that we are reverting the unsafe check. Closing the same.

@Ramesh7 Ramesh7 closed this Aug 29, 2023
@Ramesh7 Ramesh7 deleted the CAT-1351 branch August 30, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants