Maint/dnm/systemd service not found parameter #9256
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… will now return error"" This reverts commit 1818d78. Conflict in application resource.rb around a few Rubocop fixes
…resource service command This commit adds in logic that looks for the `fail_if_resource_service_not_found` parameter, if that is found and `puppet resource service <service_name>` does not exist, the command will fail and state it couldn't manage the service.
cthorn42
force-pushed
the
maint/DNM/systemd_service_not_found_parameter
branch
from
82deb70 to
32e851f
Compare
joshcooper
reviewed
Feb 20, 2024
| :type => :boolean, | ||
| :desc => "Fails the `puppet resource service` check on a given service if the service | ||
| is not found. Defaults to false", | ||
| }, |
There was a problem hiding this comment.
Since the behavior only affects the puppet resource application, I think making this an application option makes sense. Also could then be shorted to fail-when-not-found or similar? Also reminds me of the curl --fail option (to return non-zero exit code when the server returns HTTP 5xx).
|
Going with #9257 , using a command line option as suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress, to do:
binding.irbstatement and some testingputsstatements that shouldn't be there.--noflag added to fail_if_resource_service_not_found is needed, or if the testing of the negating a flag is covered else where.defaultsetting, or if we want to just tie this parameter to thepuppet resource serviceaction.